[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: kpresenter:msoffice2003:SlideNumber is not
From:       "Amit Aggarwal" <amitcs06 () gmail ! com>
Date:       2009-12-11 5:29:29
Message-ID: 20091211052929.30098.61737 () localhost
[Download RAW message or body]



> On 2009-12-10 16:15:51, Inge Wallin wrote:
> > Beside the individual comments on the small matter below, it looks fine.  Fix \
> > them and you can commit.

It done and added new diff.


> On 2009-12-10 16:15:51, Inge Wallin wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 1615
> > <http://reviewboard.kde.org/r/2353/diff/1/?file=15472#file15472line1615>
> > 
> > I'm not a friend of hardcoded names like this.  Isn't there a risk for \
> > collisions?

This thing will be changed in my next patch. 


> On 2009-12-10 16:15:51, Inge Wallin wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp, line 159
> > <http://reviewboard.kde.org/r/2353/diff/1/?file=15476#file15476line159>
> > 
> > If your getter is named headerFooterFlags(), then the setter must be named \
> > setHeaderFooterFlags()

Yes i will change it. 


> On 2009-12-10 16:15:51, Inge Wallin wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc, line 255
> > <http://reviewboard.kde.org/r/2353/diff/1/?file=15472#file15472line255>
> > 
> > Perhaps a comment on what Mpr is.

Mpr means Master Presentation style. 


> On 2009-12-10 16:15:51, Inge Wallin wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp, line 8253
> > <http://reviewboard.kde.org/r/2353/diff/1/?file=15474#file15474line8253>
> > 
> > Nitpick: shouldn't this be HeaderFooter without the s?

I will change it 


> On 2009-12-10 16:15:51, Inge Wallin wrote:
> > trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h, line 64
> > <http://reviewboard.kde.org/r/2353/diff/1/?file=15471#file15471line64>
> > 
> > These parameters in the doc are not the same as in the actual function \
> > addFrame().

Its done.


- Amit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2353/#review3398
-----------------------------------------------------------


On 2009-12-10 12:45:52, Amit Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2353/
> -----------------------------------------------------------
> 
> (Updated 2009-12-10 12:45:52)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> SildeNumber is not getting displayed in Msoffice2003 ppt. 
> 
> Changes: - 
> 1) Added style for page-number in styles.xml
> 2) Added display-page-number attribute in content.xml
> 
> Approach used to fix:- 
> 1) Convert the ppt to odp using koconverter
> 2) Verify with is required to display the page by looking the open office odp \
> format(styles and content) 3) Use MsoSchem tool to find which Atom is controlling \
> display page number. 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1060868 
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1060868 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1060868 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1060868 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.h 1060868 
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1060868 
> 
> Diff: http://reviewboard.kde.org/r/2353/diff
> 
> 
> Testing
> -------
> 
> Done testing with different document
> 
> 
> Thanks,
> 
> Amit
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]