[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: kpresenter:msoffice2003:SlideNumber is not
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2009-12-10 16:15:46
Message-ID: 20091210161546.8866.93428 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2353/#review3398
-----------------------------------------------------------
Ship it!
Beside the individual comments on the small matter below, it looks fine. Fix them \
and you can commit.
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h
<http://reviewboard.kde.org/r/2353/#comment2724>
These parameters in the doc are not the same as in the actual function \
addFrame().
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc
<http://reviewboard.kde.org/r/2353/#comment2725>
Perhaps a comment on what Mpr is.
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc
<http://reviewboard.kde.org/r/2353/#comment2726>
I'm not a friend of hardcoded names like this. Isn't there a risk for \
collisions?
trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp
<http://reviewboard.kde.org/r/2353/#comment2727>
Nitpick: shouldn't this be HeaderFooter without the s?
trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp
<http://reviewboard.kde.org/r/2353/#comment2728>
If your getter is named headerFooterFlags(), then the setter must be named \
setHeaderFooterFlags()
- Inge
On 2009-12-10 12:45:52, Amit Aggarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2353/
> -----------------------------------------------------------
>
> (Updated 2009-12-10 12:45:52)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> SildeNumber is not getting displayed in Msoffice2003 ppt.
>
> Changes: -
> 1) Added style for page-number in styles.xml
> 2) Added display-page-number attribute in content.xml
>
> Approach used to fix:-
> 1) Convert the ppt to odp using koconverter
> 2) Verify with is required to display the page by looking the open office odp \
> format(styles and content) 3) Use MsoSchem tool to find which Atom is controlling \
> display page number.
>
> Diffs
> -----
>
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1060868
> trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.h 1060868
> trunk/koffice/filters/kpresenter/powerpoint/libppt/slide.cpp 1060868
>
> Diff: http://reviewboard.kde.org/r/2353/diff
>
>
> Testing
> -------
>
> Done testing with different document
>
>
> Thanks,
>
> Amit
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic