[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add struct KoFontFace
From:       Thomas Zander <zander () kde ! org>
Date:       2009-11-29 8:23:00
Message-ID: 200911290923.01588.zander () kde ! org
[Download RAW message or body]

On Saturday 28. November 2009 13.57.19 Inge Wallin wrote:
> As for the other comment, won't that lead to very inefficient code?  The
>  class is not implicitly shared and it will lead to a lot of copies when
>  you access the list.  My suggestion is that we allow this patch to commit
>  now and if there are other issues they will show themselves and we can
>  change it afterwards.

Hmm, please not go the route of "include and fix later", I have the experience 
that that tends to not happen.

Inge, can you please fix the issues that Thorsten identified so we can move 
forward?
-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]