[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add struct KoFontFace
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2009-11-25 13:07:11
Message-ID: 20091125130711.17520.71954 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2257/
-----------------------------------------------------------

(Updated 2009-11-25 13:07:11.058516)


Review request for KOffice.


Changes
-------

Changes:
- removed KoGenStyles::removeFontFace()
- add constness to KoFontFace* KoGenStyles::fontFace()
- struct used in forward declaration (class is not really needed)
- fixed #ifdef to KOFONTFACE_H
- added more docs in KoFontFace.h


Summary
-------

Here is the first patch in a small patchset that will add filters for the MS 2007 XML \
file formats. Note that I am only the middle man here.

This patch adds the struct KoFontFace that is a public data structure representing a \
font style. It is saved as a style:font-face element. Before this patch, only the \
font name was available, which was saved as a style:name attribute of \
style:font-face. Also, svg:font-family was saved as a copy.

Now the old behaviour is still available but in addition, new attributes can be \
specified in order to make the description of a font more accurate  \
(style:font-family-generic, svg:font-style, style:font-pitch). These are needed for \
increasing quality of import/export filters and is already used in the MSOOXML \
filters. The ODF specification offers even more attributes.

The patch also contains fix for use of m_mainStyles->addFontFace() in two places, \
both in KWord.


Diffs (updated)
-----

  trunk/koffice/libs/odf/CMakeLists.txt 1053329 
  trunk/koffice/libs/odf/KoFontFace.h PRE-CREATION 
  trunk/koffice/libs/odf/KoFontFace.cpp PRE-CREATION 
  trunk/koffice/libs/odf/KoGenStyles.h 1053329 
  trunk/koffice/libs/odf/KoGenStyles.cpp 1053329 

Diff: http://reviewboard.kde.org/r/2257/diff


Testing
-------


Thanks,

Inge

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]