[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add struct KoFontFace
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2009-11-25 13:07:21
Message-ID: 20091125130721.17520.24792 () localhost
[Download RAW message or body]



> On 2009-11-22 07:23:58, Thorsten Zachmann wrote:
> > trunk/koffice/libs/odf/KoGenStyles.cpp, line 325
> > <http://reviewboard.kde.org/r/2257/diff/1/?file=14840#file14840line325>
> > 
> > Can it happen that a name could be come up two times?

Relayed from the author: 

yes it can happen in user code and will lead to memory leaks; 
Added the following note: "Declaration with given name replaces previously 
added declaration with the same name."


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2257/#review3230
-----------------------------------------------------------


On 2009-11-25 13:07:11, Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2257/
> -----------------------------------------------------------
> 
> (Updated 2009-11-25 13:07:11)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Here is the first patch in a small patchset that will add filters for the MS 2007 \
> XML file formats. Note that I am only the middle man here. 
> This patch adds the struct KoFontFace that is a public data structure representing \
> a font style. It is saved as a style:font-face element. Before this patch, only the \
> font name was available, which was saved as a style:name attribute of \
> style:font-face. Also, svg:font-family was saved as a copy. 
> Now the old behaviour is still available but in addition, new attributes can be \
> specified in order to make the description of a font more accurate  \
> (style:font-family-generic, svg:font-style, style:font-pitch). These are needed for \
> increasing quality of import/export filters and is already used in the MSOOXML \
> filters. The ODF specification offers even more attributes. 
> The patch also contains fix for use of m_mainStyles->addFontFace() in two places, \
> both in KWord. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/odf/CMakeLists.txt 1053329 
> trunk/koffice/libs/odf/KoFontFace.h PRE-CREATION 
> trunk/koffice/libs/odf/KoFontFace.cpp PRE-CREATION 
> trunk/koffice/libs/odf/KoGenStyles.h 1053329 
> trunk/koffice/libs/odf/KoGenStyles.cpp 1053329 
> 
> Diff: http://reviewboard.kde.org/r/2257/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]