[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-11-01 5:29:50
Message-ID: 200911010629.50206.t.zachmann () zagge ! de
[Download RAW message or body]

On Sat October 31 2009, Inge Wallin wrote:
> If you look at the details, there are also a lot of subtle differences
>  between  the four cases, but I guess those can be overcome with some
>  creative use of static arrays.
> 

I don't see any need for static arrays here. If you create a function taking a 
KoBorder::BorderData and 2 points as parameters no static arrays are needed.

That does not mean that I'm against the proposal you made in you mail. I think 
it an enum would have benefits and would reduce code duplication, but let the 
ones which were for the solution we have now explain why they prefer it.

Still the function reduces the code duplication in both scenarios.

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]