[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Emf libray
From:       Jos van den Oever <jos.van.den.oever () kogmbh ! com>
Date:       2009-10-25 22:57:17
Message-ID: 200910252357.17610.jos.van.den.oever () kogmbh ! com
[Download RAW message or body]

Here's my take on this. First short answers then a bit of explanation.

On Sunday 25 October 2009 13:49:43 Inge Wallin wrote:
> There are 3 questions:
> 1. Does this library belong in KOffice?
yes, but as a shape plugin, not as a library

> 2. Should the name be koemf instead of qemf?
does not matter

> 3. What is the right place for it.
inside the filter shape plugin

> 1. I think it does. There are already several similar libraries in koffice:
>   - kowmf
general library used in mswriteexport and wmfimport

>   - pigment
>   - liboofilter
liboofilter is never compiled at the moment.

>   - libppt
libppt is a static library, it is linked into libpowerpointimport.so and only 
useful for importing ppt files.

wmf support is now written by Inge as a shape. There is time pressure so 
making a nice shared library for more general use of wmf is not possible. Why 
not statically link the code into a shape like ppt support is linked 
statically into a converter plugin?

Writing clean code is still important and when there is time to add emf write 
support the code can still be refactored into a shared library.

Cheers
Jos


-- 
Jos van den Oever, software architect
+49 391 25 19 15 53
http://kogmbh.com/legal/
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]