[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KDE/kdelibs/kross
From:       Jos van den Oever <jos.van.den.oever () kogmbh ! com>
Date:       2009-09-23 19:41:37
Message-ID: 200909232141.37753.jos.van.den.oever () kogmbh ! com
[Download RAW message or body]

On Wednesday 23 September 2009 21:12:09 Thomas Zander wrote:
> On Wednesday 23. September 2009 21.02.45 Thomas Zander wrote:
> > SVN commit 1027291 by zander:
> >
> > Fix crashes on exit of the command line runner for some modules.
> >
> > This changes the unloading of a module to no longer be done
> > at library unload (which is when the singleton destructor is called),
> > but at exit of main.
> > This solves deletion order being different based on which context kross
> > (the lib) is used.  Now its explicit that module data (like documents)
> > are deleted first before any library unloading is done.
> 
> The discussion was opened on how to do testing, we suggested kross, but
> using kross hit a problem with the crash I fixed here.
> As this patch is pretty simple and the files touched have not been changed
> for over a year it should be perfectly fine to use kross with this patch
> backported on the testing machine for any automated testing.
> 
> Let me know if this solves the issue or not, please.

The issue was that there were two static instances:
 1 Kross::Manager
 2 KoPluginLoader

When running kross command-line, the destructor of KoPluginLoader is called 
before that of Kross::Manager. You have reverted this order by 
unloading/deleting the kross modules and the documents therein earlier.

It's still ugly, but it should fix the crash.

Cheers,
Jos


_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]