[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/karbon/plugins/tools
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2009-08-20 10:13:27
Message-ID: ae32c1ef0908200313g6abadb12w98664e3280e3f88d () mail ! gmail ! com
[Download RAW message or body]

Btw, Qt documentation suggests not to compare any values with zero. [0]
Shouldn't we take it into account here?

[0] http://doc.trolltech.com/4.6-snapshot/qtglobal.html#qFuzzyCompare-6



2009/8/20 Ana Beatriz Guerrero López <ana@ekaia.org>:
> SVN commit 1013597 by anagl:
>
> Fixes for ARM architecture.
>
>
>
>  M  +6 -6      KarbonCurveFit.cpp
>
>
> --- trunk/koffice/karbon/plugins/tools/KarbonCurveFit.cpp #1013596:1013597
> @@ -54,7 +54,7 @@
>
>        void normalize(){
>                qreal len=length();
> -        if (qFuzzyCompare(len, 0.0)) {
> +        if (qFuzzyCompare(len, qreal(0.0))) {
>             return;
>         }
>                m_X/=len; m_Y/=len;
> @@ -67,7 +67,7 @@
>
>        void scale(qreal s){
>                qreal len = length();
> -        if (qFuzzyCompare(len, 0.0)) {
> +        if (qFuzzyCompare(len, qreal(0.0))) {
>             return;
>         }
>                m_X *= s/len;
> @@ -133,7 +133,7 @@
>     }
>
>     qreal denominator = u[last-first];
> -    if (qFuzzyCompare(denominator, 0.0)) {
> +    if (qFuzzyCompare(denominator, qreal(0.0))) {
>         denominator = Zero;
>     }
>
> @@ -284,9 +284,9 @@
>     det_X_C1  = X[0]    * C[1][1] - X[1]    * C[0][1];
>
>     /* Finally, derive alpha values    */
> -    if (qFuzzyCompare(det_C0_C1, 0.0)) {
> +    if (qFuzzyCompare(det_C0_C1, qreal(0.0))) {
>                det_C0_C1 = (C[0][0] * C[1][1]) * 10e-12;
> -        if (qFuzzyCompare(det_C0_C1, 0.0)) {
> +        if (qFuzzyCompare(det_C0_C1, qreal(0.0))) {
>             det_C0_C1 = Zero;
>         }
>     }
> @@ -421,7 +421,7 @@
>     denominator = (Q1_u.x()) * (Q1_u.x()) + (Q1_u.y()) * (Q1_u.y()) +
>                          (Q_u.x() - P.x()) * (Q2_u.x()) + (Q_u.y() - P.y()) * (Q2_u.y());
>
> -    if (qFuzzyCompare(denominator, 0.0)) {
> +    if (qFuzzyCompare(denominator, qreal(0.0))) {
>         denominator = Zero;
>     }
>
>



-- 
Dmitry Kazakov
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]