'Re: koffice/plugins/pictureshape'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/plugins/pictureshape
From:       Cyrille Berger <cberger () cberger ! net>
Date:       2009-07-31 14:44:26
Message-ID: 200907311644.27442.cberger () cberger ! net
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

While I agree that having review of significant change before commit would be a 
good practise, I think it's worth to remember that all of us we often do 
commit big changes with limited review. Since we have no rules on the subject, 
if someone want to change that, I suggest him/her to start a new thread to 
defines the rules of "big" commits and reviews.

For this thread, I suggest we start focusing on finding a solution.

Either with KoShape::waitUntilReady() or with the shape manager. It's worth to 
note that using a shape manager would also trigger a repaint of the slide in 
the document layout when a shape is edited or moved (if we think it's too much 
CPU, it's also possible to delay that repaint, but it would still be nicer 
than to wait for Qt the model for a new version when Qt decides to repaint the 
list).

-- 
Cyrille Berger

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">While I agree that having review of significant \
change before commit would be a good practise, I think it's worth to remember that \
all of us we often do commit big changes with limited review. Since we have no rules \
on the subject, if someone want to change that, I suggest him/her to start a new \
thread to defines the rules of "big" commits and reviews.<br> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>For \
this thread, I suggest we start focusing on finding a solution.<br> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>Either with KoShape::waitUntilReady() or with the shape \
manager. It's worth to note that using a shape manager would also trigger a repaint \
of the slide in the document layout when a shape is edited or moved (if we think it's \
too much CPU, it's also possible to delay that repaint, but it would still be nicer \
than to wait for Qt the model for a new version when Qt decides to repaint the \
list).<br> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>-- <br> Cyrille Berger</p></body></html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 