[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Improve the toolbox layout
From:       "Jan Hambrecht" <jaham () gmx ! net>
Date:       2009-07-14 19:17:21
Message-ID: 20090714191721.5639.52135 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/782/#review1594
-----------------------------------------------------------

Ship it!


There is one minor issue, which is that the separator line between the main tools and \
the dynamic tools is not shown on startup. It only appears when i resize the toolbox. \
This is happening in Karbon with the toolbox vertically on the left side. Other than \
that works great.

- Jan


On 2009-07-14 12:46:48, Peter Simonsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/782/
> -----------------------------------------------------------
> 
> (Updated 2009-07-14 12:46:48)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Two parts to this diff:
> * Simplify the layout algo for the toolbox. The current approach just breaks to \
> easily, see for example the default layout of kpresenter. The new algorithm uses a \
> different orientation depending on where the toolbox is docked, this takes us to \
>                 the second part of the diff...
> * Save the area the dockwidget is docked in to work around the fact that Qt always \
> reports the default area on start up even if the dockwidget is saved in another \
> area. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/main/KoToolBox.cpp 996242 
> trunk/koffice/libs/main/KoToolBox_p.h 996242 
> 
> Diff: http://reviewboard.kde.org/r/782/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]