[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Memory leakage in indirect painting support of
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-07-14 7:36:39
Message-ID: 20090714073639.20506.94197 () localhost
[Download RAW message or body]



> On 2009-07-13 19:31:09, Boudewijn Rempt wrote:
> > Please commit -- after having run all unittests , of course :-)
> 
> Dmitry Kazakov wrote:
> Ok. =) There are some fails without these patches.. Should i count them?

I know we've got some failing unittests. As long as the patch doesn't increase the \
number, it's ok. We really need to fix those unittests, and I am working on that, but \
the problems are quite hard.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/991/#review1577
-----------------------------------------------------------


On 2009-07-11 20:38:58, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/991/
> -----------------------------------------------------------
> 
> (Updated 2009-07-11 20:38:58)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Transaction for indirect painting is never(!) deleted. This causes shared pointer \
> KisTransaction::Private::paintDevice store forever(!) paintDevice that we created \
> for indirect painting temporarily. So many-many-many tiles are kept in memory \
> forever. 
> 
> Diffs
> -----
> 
> trunk/koffice/krita/ui/tool/kis_tool_freehand.cc 991863 
> 
> Diff: http://reviewboard.kde.org/r/991/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]