[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fixed default-style tag,
From: Pierre Stirnweiss <pierre.stirnweiss () t-online ! de>
Date: 2009-04-18 7:00:41
Message-ID: 200904180900.42018.pierre.stirnweiss () t-online ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Le samedi 18 avril 2009 06:13:40, Thorsten Zachmann a écrit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/602/#review953
> -----------------------------------------------------------
>
> Ship it!
>
>
> It looks good.
>
>
> trunk/koffice/kword/part/KWOdfWriter.cpp
> <http://reviewboard.kde.org/r/602/#comment655>
>
> I think the closing of the store should be done in KWOdfWriter::save.
> At the moment the return value from here is not forwared to the caller of
> as KWOdfWriter::save. It also makes it easier to see that the store that is
> created gets deleted again.
>
Modified and commited. Thomas, can you backport it to 2.0? (or anybody else for
that matter).
I should stop postponing the set-up of my local 2.0 git repo.
Pierre
[Attachment #5 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:10pt; \
font-weight:400; font-style:normal;">Le samedi 18 avril 2009 06:13:40, Thorsten \
Zachmann a écrit :<br> > \
-----------------------------------------------------------<br> > This is an \
automatically generated e-mail. To reply, visit:<br> > \
http://reviewboard.kde.org/r/602/#review953<br> > \
-----------------------------------------------------------<br> ><br>
> Ship it!<br>
><br>
><br>
> It looks good.<br>
><br>
><br>
> trunk/koffice/kword/part/KWOdfWriter.cpp<br>
> <http://reviewboard.kde.org/r/602/#comment655><br>
><br>
> I think the closing of the store should be done in KWOdfWriter::save.<br>
> At the moment the return value from here is not forwared to the caller of<br>
> as KWOdfWriter::save. It also makes it easier to see that the store that is<br>
> created gets deleted again.<br>
><br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>Modified and commited. Thomas, can you backport it to 2.0? \
(or anybody else for that matter).<br> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>I should stop \
postponing the set-up of my local 2.0 git repo.<br> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>Pierre</p></body></html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic