From koffice-devel Sat Apr 18 07:00:41 2009 From: Pierre Stirnweiss Date: Sat, 18 Apr 2009 07:00:41 +0000 To: koffice-devel Subject: Re: Review Request: Fixed default-style tag, Message-Id: <200904180900.42018.pierre.stirnweiss () t-online ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=124022451614305 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0093441250==" --===============0093441250== Content-Type: multipart/alternative; boundary="Boundary-00=_aqX6JTMRW8NsVXu" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-00=_aqX6JTMRW8NsVXu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Le samedi 18 avril 2009 06:13:40, Thorsten Zachmann a =C3=A9crit : > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/602/#review953 > ----------------------------------------------------------- > > Ship it! > > > It looks good. > > > trunk/koffice/kword/part/KWOdfWriter.cpp > > > I think the closing of the store should be done in KWOdfWriter::save. > At the moment the return value from here is not forwared to the caller of > as KWOdfWriter::save. It also makes it easier to see that the store that = is > created gets deleted again. > Modified and commited. Thomas, can you backport it to 2.0? (or anybody else= for=20 that matter). I should stop postponing the set-up of my local 2.0 git repo. Pierre --Boundary-00=_aqX6JTMRW8NsVXu Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable p, li { white-space: pre-wrap; }Le samedi 18 avril 2009 06:13:40, Thorsten Zachmann a =C3=A9= crit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/602/#review953
> -----------------------------------------------------------
>
> Ship it!
>
>
> It looks good.
>
>
> trunk/koffice/kword/part/KWOdfWriter.cpp
> <http://reviewboard.kde.org/r/602/#comment655>
>
> I think the closing of the store should be done in KWOdfWriter::sa= ve.
> At the moment the return value from here is not forwared to the caller= of
> as KWOdfWriter::save. It also makes it easier to see that the store th= at is
> created gets deleted again.
>


Modified and commited. Thomas, can you backport it to= 2.0? (or anybody else for that matter).


I should stop postponing the set-up of my local 2.0 g= it repo.


Pierre

--Boundary-00=_aqX6JTMRW8NsVXu-- --===============0093441250== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0093441250==--