[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Doubled fullscreen action in shortcuts editor
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-02-22 12:13:46
Message-ID: 20090222121346.30508.87882 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/143/#review229
-----------------------------------------------------------

Ship it!


Looks good to me.

- Boudewijn


On 2009-02-20 16:15:40, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/143/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 16:15:40)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The fullscreen action was added to two action collections. First in the \
> KoMainWindow and the second time in KoView. From the svn log it seems it was added \
> in KoView just to be able to put it into the menu of the view. What I changed is \
> that the action is now retrieved from the mainwindow in the KoView::action() method \
> which is used to get the actions described in the rc file of the application. All \
> seems to work as expected, but to be sure there is not more to it that gets broken \
> I post the patch here for review. 
> 
> This addresses bug 157383.
> https://bugs.kde.org/show_bug.cgi?id=157383
> 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/main/KoView.cpp 929165 
> 
> Diff: http://reviewboard.kde.org/r/143/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]