[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Remove recursion form KoShapeCreateCommand
From:       Thomas Zander <zander () kde ! org>
Date:       2009-02-22 10:02:31
Message-ID: 200902221102.31451.zander () kde ! org
[Download RAW message or body]

Yes, that sounds like the good thing to do. Please commit.

On Sunday 22. February 2009 10:06:29 Thorsten Zachmann wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/149/
> -----------------------------------------------------------
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> If container e.g. a chart is added to document addShape is called with
> the KoShape *  for the container multiple times. (8 times for the chart
> shape). Looks like that went in due to a small bug. This patch removes
> the recursing of subshapes as it looks like all works without doing this.
> This fixes a crash in kspread where a embedded chart is tried to save 8
> times.
>
>
> Diffs
> -----
>
>   trunk/koffice/libs/flake/commands/KoShapeCreateCommand.h 929806
>   trunk/koffice/libs/flake/commands/KoShapeCreateCommand.cpp 929806
>
> Diff: http://reviewboard.kde.org/r/149/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thorsten
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel



-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]