[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    weeding my way through warnings...
From:       Andrew <andrew.dorrell () gmail ! com>
Date:       2008-11-17 12:02:20
Message-ID: 200811172302.20999.andrew.dorrell () gmail ! com
[Download RAW message or body]

Suggest the following patch (or equivalent) would be good practice as well as 
getting rid of a compile warning.  Applies to 
koffice/kexi/koproperty2/koproperty/Set.h

The relevant warning appears 73 times in a full koffice build:

/home/kdev/kde/src/koffice/kexi/koproperty2/koproperty/Set.h:50: warning: ‘class 
KoProperty::Set::PropertySelector' has virtual functions and accessible non-
virtual destructor

.


Index: Set.h
===================================================================
--- Set.h       (revision 884927)
+++ Set.h       (working copy)
@@ -49,6 +49,7 @@
     class KOPROPERTY_EXPORT PropertySelector
     {
     public:
+       virtual ~PropertySelector() {};
         virtual bool operator()(const Property& prop) const = 0;
     };
     //! A class to iterate over a Set.

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]