[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: facrtorial functions in kspread
From: Andrew <andrew.dorrell () gmail ! com>
Date: 2008-11-17 7:36:47
Message-ID: 200811171836.47444.andrew.dorrell () gmail ! com
[Download RAW message or body]
Couple of things:
1. the built in documentation for the fact function says the argument is a
floating point number. But the function should only take a non-negative
integer. The current implementation truncates floating point arguments.
2. the code uses a recursive implementation. Yuck. See for example
http://stackoverflow.com/questions/231250/how-would-you-write-a-non-recursive-
algorithm-to-calculate-factorials
3. Is the two argument version of fact *only* required to permit recursive
implementation
Sorry - its relatively minor as things go but worth pointing out.
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic