[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Selecting image when inserting picture shape
From:       Thomas Zander <zander () kde ! org>
Date:       2008-11-16 9:07:14
Message-ID: 200811161007.16881.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 14. November 2008 23:43:45 jaham@gmx.net wrote:
> I took the opportunity to fix a usability which we briefly discussed at
> the last KOffice meeting. This makes it possible to have a file dialog
> pop up when a picture shape is inserted into a document. To not have the
> file dialog shown in the shape properties docker i added a new function
> KoShapeConfigWidgetBase::showOnShapeSelect which controls if a shape
> config widget is shown inside the shape properties docker when the
> corresponding shape is selected.

Hi,

Thanks for working on this!

Some questions;

You added functionality to the shape properties docker. Which is not enabled 
per default. Would that functionality to show the file dialog not be better 
fitting in the tool properties docker?

The configWidgetBase has the API showOnShapeCreate(). Which is indeed 
different, yet similar to your new showOnShapeSelect().
Would it be possible to just reuse that method and way of working instead of 
introducting a new feature?

-- 
Thomas Zander

["signature.asc" (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]