[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: pagestyles branch
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2008-08-16 15:39:55
Message-ID: 200808161739.55913.mail () dipe ! org
[Download RAW message or body]

On Saturday 16 August 2008, Thomas Zander wrote:
> > > * KWPageManager::addPageSettings seems to leak an instance of
> > > KWPageSettings if the name has been added before.
> >
> > It should never happen,
>
> The name inserted is a user name, right?  Can't you have a document that
> has the same name twice?
> Or a document with the name "Standard" (which you hardcode)...

It's not the user visible name but the internal one and each pagestyle needs 
to define a unique pagestyle. E.g. in the case of "Standard" it's the default 
hardcoded internal name in OO.org (user can't change it though UI) while the 
visible name is "Default".

Re hardcoded; yes, that's really a bit annoying. We where discusing it too if 
it needs to be more flexible and iirc came to the conclusion that we may just 
like to (re-)add the possibility to set the masterpagename (that's commented 
out yet and needed in the ctor to prevent to have inconsistency between the 
name in the kwpagesettings-instance and those used in the QMap as key).

Beside "Standard" OO.org comes with some other "default page styles" where the 
user is not able to change the internal name. Anyway, the intention to 
hardcode it for now (was before the case too btw but in the KWOdfSaver and 
iirc it was the case in 1.6 too) was to don't special case the "Standard" (or 
other) default styles any longer but just handle them as yet another 
pagestyle ;)

Also it seems there is or at least I failed to find any details about this in 
the specs :-/
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]