[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: pagestyles branch
From:       Thomas Zander <zander () kde ! org>
Date:       2008-08-16 8:19:02
Message-ID: 200808161019.02945.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 15. August 2008 23:31:19 Pierre wrote:
> On Friday 15 August 2008 10:16:54 Thomas Zander wrote:
> > * KWDocument::frameSetAdded / Removed signals have been removed, why?
> > I think they should stay.
>
> Sebastian removed them because they were unused.
> I won't answer for him, but I think removing unused things can be good
> (even if I don't really like doing this in the middle of other changes)

I was thinking about scripting, but we can always add them again later.
you probably want to remove the emit calls too instead of having them 
commented out like it is currently.


> > * the KWPage::OrientationHint seems to have been commented out, why?
>
> My bad, I forgot to remove it after commenting it and fixing the code,
> sorry. (The layout isn't stored in KWPage anymore)

So this information is not stored anymore?  At least I can't find it...
We still need it to correctly show the page size in the dialog and to rotate 
the page on printing to a printer...  (as printers typically don't allow 
landscape printing ;)

> > * KWPageManager::addPageSettings seems to leak an instance of
> > KWPageSettings if the name has been added before.
>
> It should never happen, 

The name inserted is a user name, right?  Can't you have a document that has 
the same name twice?
Or a document with the name "Standard" (which you hardcode)...

> and I don't really see a way to properly deal with 
> this.

Hmm, thinking about this longer; if KWPageSettings becomes a shared data 
object we can just insert the data instead of a pointer to it. No more 'new' 
and ref-counted deletion of data.  ;)
Problem solved.

> > * Can we rename KWPageSettings to something that looks more like
> > MasterPageData ?
>
> Sure, that's what I told you monday, renaming it after the merge.
> But I'd rather go for KWPageStyle, to mimic KoParagraphStyle,
> KoListStyle... So, should we do it the democratic way ?
> I vote for "KWPageStyle" :)

Fine with me :)
-- 
Thomas Zander

["signature.asc" (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]