[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: merge pagestyle changes back to trunk
From:       Pierre <pinaraf () pinaraf ! info>
Date:       2008-08-11 16:41:35
Message-ID: 200808111841.35473.pinaraf () pinaraf ! info
[Download RAW message or body]

On Monday 11 August 2008 17:40:17 Pierre wrote:
> As you probably saw, a lot of commits came to clean up everything :)
>
> On Monday 11 August 2008 14:13:09 Thomas Zander wrote:
> > There have been several signatures that have been changed and I think we
> > should have the API docs fixed / extended for those.  Especially the
> > addition of arguments is something we should add before the integration,
> > but also the class doc of KWPage.
>
> DONE (wow, the hardest part)
>
> > Remove FIXME (its fine) in kwdocument.h and please add some api docs to
> > that method. (copy paste is enough)
>
> DONE
>
> > PageSettings has framesets pointers, who deletes them?
>
> It's pageSettings job to delete them. I removed the copy constructor from
> KWPageSettings, not used anymore and creating problems with these pointers.
> DONE
Led to crashes.
Any KWTextFrameSet has to belong to the KWDocument. KWPageSettings belong to 
the KWDocument too. I don't see any way to get a problem if KWPageSettings let 
KWDocument delete the framesets...
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]