[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: merge pagestyle changes back to trunk
From:       Pierre <pinaraf () pinaraf ! info>
Date:       2008-08-11 16:20:11
Message-ID: 200808111820.11451.pinaraf () pinaraf ! info
[Download RAW message or body]

On Monday 11 August 2008 17:40:17 Pierre wrote:
> As you probably saw, a lot of commits came to clean up everything :)
>
> On Monday 11 August 2008 14:13:09 Thomas Zander wrote:
> > There have been several signatures that have been changed and I think we
> > should have the API docs fixed / extended for those.  Especially the
> > addition of arguments is something we should add before the integration,
> > but also the class doc of KWPage.
>
> DONE (wow, the hardest part)
>
> > Remove FIXME (its fine) in kwdocument.h and please add some api docs to
> > that method. (copy paste is enough)
>
> DONE
>
> > PageSettings has framesets pointers, who deletes them?
>
> It's pageSettings job to delete them. I removed the copy constructor from
> KWPageSettings, not used anymore and creating problems with these pointers.
> DONE
>
> > Unit tests :)  I noted that at least one didn't compile, I'd like it if
> > we can even make them pass.
>
> Now they compile, but they may segfault/fail... Work in progress...
> But I think that it's already enough for the merge, isn't it ?
>
> > Please test the usecases of adding and then removing and then again
> > adding a header.
> > This crashed in kword 1.4 and again in 1.6.  Lets break the cycle ;)
> > The changes in KWView don't all feel right, having a menu for all the
> > headers seems odd to me. I have not managed to compile the branch (due to
> > the unit tests) so I'm not sure what it looks like.
> > I can look again later but I would like to just have minimal changes to
> > that UI for now.
>
> Sebastian, that's your changes, can you look at this please ?
>
> > PageSpreads should still work. They work in trunk.  (start kword, in the
> > start window use the widget to create a custom document. Enabled "Facing
> > pages")
>
> Seeing strange things with it so far, I'll look at this.
It's a bit more complex.
Fixing this problem means changing the KoPageLayout struct. Most members 
should be then private, have getter/setter and handle there the page 
spreading.
I don't really like this...
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]