[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake
From:       Thomas Zander <zander () kde ! org>
Date:       2007-11-25 14:29:55
Message-ID: 200711251529.56159.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 25 November 2007 13:42:48 jaham wrote:
> On Sunday 25 November 2007 12:30:40 Thomas Zander wrote:
> > On Sunday 25 November 2007 12:03:51 jaham wrote:
> > > On Sunday 25 November 2007 08:59:52 Thorsten Zachmann wrote:
> > > > Hello Jan,
> > > >
> > > > > SVN commit 740935 by jaham:
> > > > >
> > > > > Some default tool option widget goodness. One can now select
> > > > > the corner of the selection for which to change the position.
> > > > > The selected corner is highlighted by the selection decorator
> > > > > for better user feedback as the corners can be at quite
> > > > > different positions if the selection is transformed.
> > > >
> > > > cool.
> > > >
> > > :-)
> > > :
> > > > There is a small problem with the position of the highlighted
> > > > position after you undo a resize, rotate and so on.
> > >
> > > Yeah i know. That problem we have all over the place. There is atm
> > > no way to know when a command was undone. :-( Do you know how to
> > > make this work?
> >
> > Good point; we basically need a notifycation from the data model that
> > a shape has been changed so the view (widgets) can update their data.
> > Can you try the attached patch?  If you then connect to the
> > KoShapeManager::selectionContentChanged() signal you should be able
> > to fix the problem.
> >
> > Let me know.
>
> That is a step in the right direction. There is still one problem
> though. The selection is not updated when undoing a transformation
> command. As the selection is a shape, maybe we could add it to the list
> of shapes a command is working on? Or is that a stupid idea?

THanks for reviewing the patch; I was unsure if it actually worked. I 
finished my recompile and added a call to the selection to let it refresh 
its bounding rect, and committed it.

Please try to use the signal and let me know if you find anything wrong 
with it.
-- 
Thomas Zander

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]