[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/flake
From:       jaham <jaham () gmx ! net>
Date:       2007-11-25 14:36:48
Message-ID: 200711251536.48636.jaham () gmx ! net
[Download RAW message or body]

On Sunday 25 November 2007 15:29:55 Thomas Zander wrote:
> On Sunday 25 November 2007 13:42:48 jaham wrote:
> > On Sunday 25 November 2007 12:30:40 Thomas Zander wrote:
> > > On Sunday 25 November 2007 12:03:51 jaham wrote:
> > > > On Sunday 25 November 2007 08:59:52 Thorsten Zachmann wrote:
> > > > > Hello Jan,
> > > > >
> > > > > > SVN commit 740935 by jaham:
> > > > > >
> > > > > > Some default tool option widget goodness. One can now select
> > > > > > the corner of the selection for which to change the position.
> > > > > > The selected corner is highlighted by the selection decorator
> > > > > > for better user feedback as the corners can be at quite
> > > > > > different positions if the selection is transformed.
> > > > >
> > > > > cool.
> > > > >
> > > > :-)
> > > > :
> > > > > There is a small problem with the position of the highlighted
> > > > > position after you undo a resize, rotate and so on.
> > > >
> > > > Yeah i know. That problem we have all over the place. There is atm
> > > > no way to know when a command was undone. :-( Do you know how to
> > > > make this work?
> > >
> > > Good point; we basically need a notifycation from the data model that
> > > a shape has been changed so the view (widgets) can update their data.
> > > Can you try the attached patch?  If you then connect to the
> > > KoShapeManager::selectionContentChanged() signal you should be able
> > > to fix the problem.
> > >
> > > Let me know.
> >
> > That is a step in the right direction. There is still one problem
> > though. The selection is not updated when undoing a transformation
> > command. As the selection is a shape, maybe we could add it to the list
> > of shapes a command is working on? Or is that a stupid idea?
>
> THanks for reviewing the patch; I was unsure if it actually worked. I
> finished my recompile and added a call to the selection to let it refresh
> its bounding rect, and committed it.
>
> Please try to use the signal and let me know if you find anything wrong
> with it.

I already tried that and it works for position and size changes. Rotation and 
shear changes do not work, as selection->updateSizeAndPosition does only 
update size and position of the selection. So if you rotate the selection and 
undo that command, the selection is not updated correctly.

Ciao Jan

[prev in list] [next in list] [prev in thread] [next in thread]