[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Berlin Sprint Action List Update
From:       Thomas Zander <zander () kde ! org>
Date:       2007-11-08 19:05:02
Message-ID: 200711082005.02661.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 05 November 2007 15:46:07 Boudewijn Rempt wrote:
> * all apps need the style manager, because now everyone crashes when a new
> style is added, except KWord. It is a document-wide resource, so
> KoCanvasResourceProvider is not the right place. Maybe KoDocument?

There are two things;
a) it needs to be stored document wide
b) it needs to be added to each QTextDocument instance used (in a kotext 
shape).

Storing it in the KoDocument is not going to be a good idea as that means it 
needs to link to libKoText. And it doesn't help anyway since the code to add 
shapes is not there anyway so point (b) can't be fulfilled here.

Now, we can add the code to have a KoStyleManager in each app and add the code 
to the addShape of each app as well. But that means that app would 
immediately link against libkotext.

So, my solution is a little added code to the text-plugin.  It will 
automatically create a styleManager for each text-shape that doesn't have 
one. Allowing the text shape to have styles.
This, however, will not share the textstyles among all shapes in that 
document.  If an application wants that, he has to add the code in his 
document.

I added the code to KoPADocument. I don't see shared styles being a really 
useful feature for our other apps. Naturally the app-maintainers can choose 
to link to KoText and add this piece of code, if they want :)

Cheers!
-- 
Thomas Zander

["signature.asc" (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]