[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2007-09-18 5:30:38
Message-ID: 200709180730.38728.t.zachmann () zagge ! de
[Download RAW message or body]

Hello Jan,

> SVN commit 713647 by jaham:
>
> fix crash when closmerging a path with less than 2 points
>
>
>  M  +1 -1      KoPathShape.cpp
>
>
> --- trunk/koffice/libs/flake/KoPathShape.cpp #713646:713647
> @@ -1059,7 +1059,7 @@
>
>  void KoPathShape::closeMergeSubpath( KoSubpath *subpath )
>  {
> -    if ( ! subpath )
> +    if ( ! subpath || subpath->size() < 2 )
>          return;
>
>      KoPathPoint * lastPoint = subpath->last();

It is fully possible to close a a path with only one point. Can you please 
revert the commit.

The problem that kword was crashing is that kword also uses the key press 
event of the left mouse press to open a context menu. This is wrong as the 
path tool no longer receives the mouse release event for the mouse press. I 
tried to fix this yesterday in kword by checking if the mouse event was 
already accepted, but it was not possible to do so as all the tools accepted 
the mouse press by default. So the correct solution to the problem is to not 
accept the left mouse press in all the tools that do not use it. 

Thanks

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]