[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: loading of raw xml
From:       Dag Andersen <danders () get2net ! dk>
Date:       2007-04-03 11:07:03
Message-ID: 200704031307.03382.danders () get2net ! dk
[Download RAW message or body]

Sigh, yesterday wasn't the best of days...
Can't reproduce this, today things works as expected, so just disregard these 
mails, please.
Mandag 02 april 2007 11:19 skrev Dag Andersen:
> Sorry, got the commit totally wrong, the test has been there a loooong
> time. (But I still think the code is wrong)
>
> The actual code is in KoDcument.cpp line 1750 in loadNativeFormat():
>
> if ( d->m_specialOutputFlag != SaveAsDirectoryStore ) // Don't try to open
> a directory ;)
>     {
>         in.setFileName(file);
>         if ( !in.open( QIODevice::ReadOnly ) )
> ...
>
> I don't see why the check for SaveAsDirectoryStore when we are actually
> loading. And as I say below it seems to me it will *always* end up trying
> to load oasis format, so "old" format will not work.
>
> Anyone?
>
> Mandag 02 april 2007 09:16 skrev Dag Andersen:
> > Hi, David
> > I found this commit:
> > http://lists.kde.org/?l=kde-commits&m=116921539415804&w=2
> > I don't think this works if the raw xml is in the "old" format
> > (maindoc.xml) the test:
> > if ( d->m_specialOutputFlag != SaveAsDirectoryStore )
> > seems wrong to me. AFAICS it will *always* try to load oasis format.
> > If I remove the test, I can load "old" format just fine.
> > Have I missed something, or is it ok to remove the test?

-- 
Mvh
Dag Andersen
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]