[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/store
From:       Stefan Nikolaus <stefan.nikolaus () kdemail ! net>
Date:       2007-02-13 13:53:14
Message-ID: 200702131453.15201.stefan.nikolaus () kdemail ! net
[Download RAW message or body]

On Tuesday 13 February 2007 13:09:34 you wrote:
> SVN commit 633164 by zander:
>
> Don't have a d pointer when you don't actually use it.
>
>
>  M  +0 -2      KoStore.cpp
>  M  +0 -4      KoStore.h

This time I object: ;-)
The d-pointer is in a _public class_ in the kostore _lib_. It can save your 
ass, after the ABI gets frozen. You never know, wether you'll need some 
additional member vars in future. There are other tricks to add a member 
variable and preserve BC, like deriving from the class first and then add the 
member, but those are dirty and need to/should be cleaned up with the next 
BIC release.
You should prefer the d-pointer unless you have good reason not to do so (an 
often used object, like a cell in a spreadsheet, may be a good one ;-) ) In 
this case the class is not often used (once per document), so the few extra 
bytes for the pointer don't hurt.

Regards,
the guy, who obviously gets triggered by the term 'd pointer' lately ;-)
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]