[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake
From:       Thomas Zander <zander () kde ! org>
Date:       2007-02-08 20:51:35
Message-ID: 200702082151.46169.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 08 February 2007 21:09, Boudewijn Rempt wrote:
> On Thursday 08 February 2007, Thomas Zander wrote:
> > On Thursday 08 February 2007 14:38, you wrote:
> > > On Thursday 08 February 2007, you wrote:
> > > > SVN commit 631571 by zander:
> > > >
> > > > Using a QRegion in document coordinate system can't work for any
> > > > useful document. So I'll mark this method deprecated, to be removed
> > > > before the final release.
> > >
> > > And I'll unmark it deprecated again because you're totally wrong.
> >
> > Ehm, right.
> > That explains everything.
>
> As if your bald commit statement or your comments on irc explained
> anything.

I designed and programmed the coordinate system translation stuff in 
flake/koffice. Its entirely possible I don't explain it fully enough, I tend 
to assume things are obvious, but naturally they are not.
Its Ok for anyone to ask if my explanation leaves you hanging.
That said; your statement:
  "because you're totally wrong"
is not a way of communicating I can accept. Its not how I want to work with 
people.

> > Before we go ping-pong commits, you might want to explain why you think
> > you don't need something more higher resultion then whole postscript
> > points. (aka 72 DPI).
>
> Well, you don't have to use that method. Besides, "he who code decides",
> right?

Well, I did the code and design for the coordinate conversion and you added a 
method that I don't think belongs because its not following the design and 
anything build on top of it will get unwanted sideeffects.

> Not that I'm not working on a version of QRegion that takes floats and
> doesn't degrade to scanlines to replace QRegion here and elsewhere in
> Krita. I'll have to base it on a grid, so you'll have the same kind of
> imprecision you'd get if you'd add aligned rects to the qregion, but for
> updating a canvas that isn't a problem, better paint a little too much than
> not enough.

Please, deflate your ego a bit. You are not being reasonable.

The correct way to do this is to call the updateCanvas(QRectF) multiple times 
instead of calling it one time with a QRegion.  This will correctly convert 
to pixels and will correctly collect all rects to be repainted in one go.

Boudewijn; I'm getting VERY tired of the way you communicate. You act like you 
are always right, sorry nobody is always right.
And if someone criticizes your work then take that critique and use it. Don't 
see it as a personal attack and don't respond by attacking the messager. You 
will make others stop wanting to work with you.
I know, I've been there. And gotten over it.
-- 
Thomas Zander

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]