[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [patch] Make LEFT() and RIGHT() closer to spec.
From:       Brad Hards <bradh () frogmouth ! net>
Date:       2006-12-18 10:25:41
Message-ID: 200612182125.47836.bradh () frogmouth ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


The patch below makes the length attribute optional for LEFT() and RIGHT().

I'm not really sure about it - never done this kind of patch for kspread 
formula before.

Does it look OK?

Can I just commit it to subversion, or is there some kind of review process?

Is there any coordination of kspread functions (e.g. someone is working on a 
particular set, or a list of some kind)?

Brad

Index: text.xml
===================================================================
--- text.xml    (revision 614543)
+++ text.xml    (working copy)
@@ -341,8 +341,8 @@
        <Comment>Source string</Comment>
        <Type>String</Type>
       </Parameter>
-      <Parameter>
-       <Comment>Amount of characters</Comment>
+      <Parameter optional="true">
+       <Comment>Number of characters</Comment>
        <Type>Int</Type>
       </Parameter>
       <Help>
@@ -363,8 +363,8 @@
        <Comment>Source string</Comment>
        <Type>String</Type>
       </Parameter>
-      <Parameter>
-       <Comment>Amount of characters</Comment>
+      <Parameter optional="true">
+       <Comment>Number of characters</Comment>
        <Type>Int</Type>
       </Parameter>
       <Help>
Index: text.cpp
===================================================================
--- text.cpp    (revision 614543)
+++ text.cpp    (working copy)
@@ -122,7 +122,7 @@
   f->setParamCount (1, 3);
   repo->add (f);
   f = new Function ("LEFT", func_left);
-  f->setParamCount (2);
+  f->setParamCount (1, 2);
   repo->add (f);
   f = new Function ("MID", func_mid);
   f->setParamCount (2, 3);
@@ -140,7 +140,7 @@
   f->setParamCount (2);
   repo->add (f);
   f = new Function ("RIGHT", func_right);
-  f->setParamCount (2);
+  f->setParamCount (1, 2);
   repo->add (f);
   f = new Function ("SEARCH", func_search);
   f->setParamCount (2, 3);

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]