[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KSpread Kexi Import Filter
From:       Laurent Montel <montel () kde ! org>
Date:       2006-08-18 14:45:44
Message-ID: 200608181645.46529.montel () kde ! org
[Download RAW message or body]

On Friday 18 August 2006 15:16, Stefan Nikolaus wrote:
> On Thursday 17 August 2006 00:50, Cyrille Berger wrote:
> > those two requirements:
> >  - the blessing from kspread maintainer/developers
>
> I would say okay, if ..
> 1. you add the kexi dir in the include path and remove the 'kspread'
> and 'kexi' prefixes in the include directives. Otherwise, it won't compile
> for me (caused by builddir != srcdir ?)
> 2. you add an option in the Makefile.am, so that the filter compilation
> depends on wether kexi is compiled (Non-autohell-expert-proposal: add kexi
> in filters/configure.in.mid and adjust filters/kspread/Makefile.am like
> filters/Makefile.am)
>
> If Laurent does not object, you can commit it.

For me it's ok.
Don't forget to commit into trunk too.

> >  - it _must_ be available in 2.0 as well, we can't have user relying on
> > something that will disapear in the next release
>
> Should not be that difficult, but you have to do it.
>
> Anyway, great work!
>
> Regards,
> Stefan
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]