[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: file:// vs file:///
From:       David Faure <faure () kde ! org>
Date:       2006-02-23 14:07:05
Message-ID: 200602231507.13289.faure () kde ! org
[Download RAW message or body]

On Thursday 23 February 2006 12:51, Sebastian Sauer wrote:
> Hi *,
> 
> attached is a patch that translates all remaining (at least all I found with a 
> grep ;) file:// references to file:/// as defined by opendoc, rfc and kurl.
> 
> Cause I don't know what sideeffect it would introduce to apply that patch 
> right now, I would suggest to wait with it after the final release.

All those bits of code are very wrong anyway. Removing "file://" from a url doesn't
make the result a path, the escaping is different. One needs to use KURL instead.

For instance the template stuff should read
  if ( QDir::isRelativePath( templatePath ) ) { // i.e. doesn't start with '/', on unix
    KURL url( templatePath );
    if (url.isLocalFile())
       templatePath = url.path();
    else # wow, this else is missing in the current impl, too
      templatePath = *it + templatePath;
  }

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]