[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: kspread: merging non-cont. selections into trunk
From:       Robert Knight <robertknight () gmail ! com>
Date:       2005-12-20 23:40:07
Message-ID: 13ed09c00512201540h3a3590b0n () mail ! gmail ! com
[Download RAW message or body]

Hi Stefan,

I'll review the code in more detail later, but the important thing is
that it is easy to reuse highlighted ranges for other things (eg.
chart bindings) in future.


On 20/12/05, Stefan Nikolaus <stefan.nikolaus@kdemail.net> wrote:
> On Monday, 19. December 2005 22:14, Robert Knight wrote:
> > Do you mean the newly refactored HighlightRange code? (ie. with
> > HighlightRange extending Range and the resizing code moved to the
> > reimplementation of setArea() in EditorHighlightRange)
>
> Exactly. The highlighted ranges are now a Selection and the resizing is done
> by it. Sorry, I know, that you have added the code recently and surely aren't
> be happy, that I come along and touches it.
> If you have something in your pipeline based on the HighlightRanges, let me
> know. I'll try my best to help you with adapting it to the Selection.
>
> One small issue with my code: if you have more than one highlighted range and
> resize one, the color may switch. That's because the resized range becomes
> the last and the order of the colors is static. For me, this is not nice, but
> acceptable.
>
> Bye,
> Stefan
>
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
>
>
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]