[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Loading plugins from koView subclass
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2005-10-28 12:29:45
Message-ID: 200510281429.45666.boud () valdyas ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 28 October 2005 13:53, David Faure wrote:

> This sounds like you look for plugins too early then.

So I thought, but I couldn't figure out where to do it but in the constructor.

>
> > and I get an error saying that krita.so doesn't have an init_krita
> > funciton
>
> !?!?! Where does it look for plugins, to end up finding krita.so !?

I don't know -- it's somewhere inside the call to mainWindow()->guiFactory(), 
since if I remove that line, I don't get the error.

>
> > * Or I use the factory() function of the KoView subclass (KisView) to add
> > the plugins, but then I get the crash.
>
> Where does it crash exa> ctly? 

#4  0xb78bfcd4 in KXMLGUIFactory::addClient () from /usr/lib/libkdeui.so.4
#5  0xb63bab0c in KisView (this=0x86e04e0, doc=0xb2f62fa8, adapter=0xb2f63064, 
    parent=0x8664dd8, name=0xb7f6bb0a "view")
    at ../../../koffice/krita/ui/kis_view.cc:268
#6  0xb6365b89 in KisDoc::createViewInstance (this=0xb2f62fa8, 
    parent=0x8664dd8, name=0xb7f6bb0a "view")
    at ../../../koffice/krita/ui/kis_doc.cc:870
#7  0xb7edc44c in KoDocument::createView (this=0xb2f62fa8, parent=0x8664dd8, 
    name=0xb7f6bb0a "view")
    at ../../../koffice/lib/kofficecore/koDocument.cc:306
#8  0xb7efcd57 in KoMainWindow::setRootDocument (this=0xb2f7c030, 
    doc=0xb2f62fa8) at ../../../koffice/lib/kofficecore/koMainWindow.cc:339
#9  0xb7f04d4d in KoApplication::start (this=0xbf9965f4)
    at ../../../koffice/lib/kofficecore/koApplication.cc:149
#10 0xb7f7e17e in kdemain (argc=1, argv=0xbf996784)
    at ../../koffice/krita/main.cc:38
#11 0x08048712 in main (argc=1, argv=0xbf996784) at krita.la.cc:2

>
> >     KStdAction::keyBindings( mainWindow()->guiFactory(),
> > 	SLOT( configureShortcuts() ), actionCollection() );
>
> Hmm I think we should fix KoMainWindow's configure shortcuts action
> instead. Can you test this patch?

That fixed the action problem beautifully.

> Try this instead:
>    insertChildClient(plugin);

Much better! I'll convert all the view plugins back and see whether my menus 
won't be messed up again, but it loads the plugin and doesn't crash.

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi

[Attachment #5 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]