[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Need help with Kformula internals
From:       Raphael Langerhorst <raphael-langerhorst () gmx ! at>
Date:       2005-04-04 10:51:45
Message-ID: 200504041251.45514.raphael-langerhorst () gmx ! at
[Download RAW message or body]

[resending, now to the koffice list]
On Monday 04 April 2005 12:31, you wrote:
> On Sunday 03 April 2005 21:23, Raphael Langerhorst wrote:
> > Hi Mark,
> >
> > I have looked through your patch and committed it after testing
> > it.
>
> Thank you very much Raphael you have made my week :)
>
> > Some observations: In case you press a "|" and then press a
> > different key in between and THEN press "|" again (with the
> > cursor after the first |), then there is a "normal" "|" character
> > inserted. [let me know if this sentence is not clear].
> >
> > The question is, if this behaviour is desired? I think basically
> > that this is OK, but still I wanted to raise that thought since I
> > don't know if you were considering it.
>
> I had not considered that. I think its ok like that (it's how i
> would expect it to work) but feel free to change it if you think it
> would be better another way.
>
> Could you please change the  singlePipe member variable to be a
> bool please as per David's suggestion, thank you.
>
> Could you also close
> BUG:58953 (ignore the patch on this one i jumped the gun a bit)
> BUG:32878
> BUG:34467
>
> As they are all fixed by my patch.

done :) I didn't even know so many bugs were associated with this, 
that's great!

>
> OK i shall go and see what else i can fix now.

That would be wonderful.

>
> Thanks again for all the help from everyone.
>
> Mark

And thanks to you as well for fixing these bugs.

Raphael
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]