[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [SECURITY] Newest KOffice PDF Import Filter Vulnerability
From:       Waldo Bastian <bastian () kde ! org>
Date:       2005-01-20 17:44:43
Message-ID: 200501201844.47389.bastian () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Thursday 20 January 2005 16:33, you wrote:
> Hi,
>
> A member of the debian security team has posted a bug against koffice,
> also for CAN-2005-0064.  The patch however is quite different.
>
>   http://bugs.debian.org/291245
>
> Are these the same issue?  In particular, do I need to apply both
> patches, or just one of the patches?  If just one, would you recommend
> the debian patch (included below) or the KDE patch (from your previous
> post)?

Both patches fix the same issue. The koffice patch doesn't seem to handle the 
keyLength == 0 case though. The koffice patch is the patch that went into 
xpdf upstream.

I think keyLength == 0 can cause a crash in rc4InitKey due to
	index1 = (index1 + 1) % keyLen;
although it doesn't seem to be exploitable. I will revise the koffice patch, 
see attachment.

Cheers,
Waldo
-- 
bastian@kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian@suse.com  |   http://www.novell.com/products/desktop/eval.html

["post-1.3.5-koffice.diff" (text/x-diff)]

Index: koffice/filters/kword/pdf/xpdf/xpdf/XRef.cc
===================================================================
RCS file: /home/kde/koffice/filters/kword/pdf/xpdf/xpdf/XRef.cc,v
retrieving revision 1.6
retrieving revision 1.8
diff -u -p -r1.6 -r1.8
--- koffice/filters/kword/pdf/xpdf/xpdf/XRef.cc	30 Oct 2004 16:35:33 -0000	1.6
+++ koffice/filters/kword/pdf/xpdf/xpdf/XRef.cc	20 Jan 2005 17:36:38 -0000	1.8
@@ -501,6 +501,12 @@ GBool XRef::checkEncrypted(GString *owne
 	} else {
 	  keyLength = 5;
 	}
+	if (keyLength < 1) {
+	  keyLength = 1;
+	}
+	if (keyLength > 16) {
+	  keyLength = 16;
+	}
 	permFlags = permissions.getInt();
 	if (encVersion >= 1 && encVersion <= 2 &&
 	    encRevision >= 2 && encRevision <= 3) {

[Attachment #8 (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]