[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Bug 52001: text color toolbar button does not behave as expected
From:       Sven Langkamp <longamp () reallygood ! de>
Date:       2004-10-26 14:41:18
Message-ID: 200410261641.18815.longamp () reallygood ! de
[Download RAW message or body]

Hi,
I have implemented the behavior suggested in wish 52001(currently only for 
KWord) Even though I don't know if this behavior is better concerning 
consistency and usability. What do you think?

btw: This should be a KOffice wish, not KWord.

["colorbutton.diff" (text/x-diff)]

Index: kword/kwview.cc
===================================================================
RCS file: /home/kde/koffice/kword/kwview.cc,v
retrieving revision 1.1049
diff -u -r1.1049 kwview.cc
--- kword/kwview.cc	20 Oct 2004 21:34:05 -0000	1.1049
+++ kword/kwview.cc	26 Oct 2004 14:21:36 -0000
@@ -1816,7 +1816,6 @@
         actionBackgroundColor->setText(i18n("Frame Background Color..."));
     else
         actionBackgroundColor->setText(i18n("Text Background Color..."));
-    actionFormatColor->setCurrentColor( currentFormat.color() );
     switch(currentFormat.vAlign())
       {
       case KoTextFormat::AlignSuperScript:
Index: lib/kofficeui/tkcoloractions.cpp
===================================================================
RCS file: /home/kde/koffice/lib/kofficeui/tkcoloractions.cpp,v
retrieving revision 1.30
diff -u -r1.30 tkcoloractions.cpp
--- lib/kofficeui/tkcoloractions.cpp	21 Sep 2003 17:35:00 -0000	1.30
+++ lib/kofficeui/tkcoloractions.cpp	26 Oct 2004 14:21:40 -0000
@@ -240,8 +240,7 @@
 void TKSelectColorAction::slotActivated()
 {
   //kdDebug() << "TKSelectColorAction::slotActivated" << endl;
-  // The goal is to select a color !
-  selectColorDialog();
+  activate();
 }
 
 void TKSelectColorAction::activate()


_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]