[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Bug 88417
From:       Sven Langkamp <longamp () reallygood ! de>
Date:       2004-10-22 20:31:21
Message-ID: 200410222231.21742.longamp () reallygood ! de
[Download RAW message or body]

On Friday 22 October 2004 21:58, zander@kde.org wrote:
> On Fri, Oct 22, 2004 at 07:40:29PM +0000, Michael Goldish wrote:
> > Hi all,
> >
> > Regarding KWord bug 88417 ("CTRL+UP ARROW seems to move the cursor to the
> > beginning of the PREVIOUS paragraph, rather than the beginning of the
> > current paragraph") -- I have attached an image to illustrate what I
> > meant. As far as I understand, AbiWord doesn't do the same, and I'm
> > pretty sure Word 97/2000/XP doesn't do the same either. Please correct me
> > if I'm wrong.
>
> Sven; could you please confirm or deny?
>
> just for the record; from a usability POV first moving to the start of
> current parag seems most usable, just like ctrl-left moves to start of
> current word.
My fault. My test case was wrong. So the attached patch should fix the 
problem.

["ctrluparrow.diff" (text/x-diff)]

? lib/kformula/pics/hicolor/Makefile
? lib/kformula/pics/hicolor/Makefile.in
Index: lib/kotext/kotextview.cc
===================================================================
RCS file: /home/kde/koffice/lib/kotext/kotextview.cc,v
retrieving revision 1.125
diff -u -r1.125 kotextview.cc
--- lib/kotext/kotextview.cc	13 Sep 2004 21:34:25 -0000	1.125
+++ lib/kotext/kotextview.cc	22 Oct 2004 20:23:25 -0000
@@ -474,11 +474,12 @@
             break;
         case MoveParagUp: {
             KoTextParag * parag = m_cursor->parag()->prev();
-            if ( parag )
+            if ( !m_cursor->index() && parag )
             {
                 m_cursor->setParag( parag );
                 m_cursor->setIndex( 0 );
             }
+            else m_cursor->setIndex( 0 );
         } break;
         case MoveParagDown: {
             KoTextParag * parag = m_cursor->parag()->next();


_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]