[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Bug 87700 in KSpread fixed, but is it correct?
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2004-10-20 19:42:01
Message-ID: 200410202142.01613.inge () lysator ! liu ! se
[Download RAW message or body]

Hi,

I just fixed bug 87700 for kspread, but I am not sure that I did it in the 
correct way. Maybe somebody with better knowledge of KSpread internals could 
look at it and say what he/she thinks.

The problem was that after a dissociate Cells, the top-left cell never got 
repainted. There was a call to refreshMergedCell() immediately before a call 
to "emit sigUpdateView(). I had to add a call to setLayoutDirtyFlag() for the 
cell in question, because refreshMergedCell() (indirectly) marked all cells 
in the merged cell as dirty, except the top-left one.

What I am wondering now is whether this call should be inserted into 
refreshMergedCell() instead. The patch fixes the bug in bugzilla (that was 
originally reported by me), but refreshMergedCell() is called from many other 
places, and I don't know what they all do. Maybe there are other similar 
cases that are not fixed by this patch, but that would be fixed if the call 
to setLayoutDirtyFlag() was made from within refreshMergedCell() instead.

	-Inge

-- 
Inge Wallin               | Thus spake the master programmer:               |
                          |      "After three days without programming,     |
inge@lysator.liu.se       |       life becomes meaningless."                |
                          | Geoffrey James: The Tao of Programming.         |
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]