[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Character style ui : let me know what you think
From:       David Faure <faure () kde ! org>
Date:       2004-08-27 17:59:27
Message-ID: 200408271959.27870.faure () kde ! org
[Download RAW message or body]

On Friday 27 August 2004 19:53, p.stirnweiss_koffice@bluewin.ch wrote:
> If I understood the document about binary compatibility properly, in order
> to patch KFontChooser and keep binary compatibility, I should create a new
> constructor which take one more argument "bool showPreview=True", and indicate
> in the code to merge it with the default constructor in next binary compat
> breaking. I should not just add an extra argument to the default constructor.
> Am I correct?
Yes, except for the default value of the bool. Before the merging, you can't
have the "=true" part, this would lead to ambiguous calls.

> I guess I should submit the patch to kde-devel?
kde-core-devel, for such a core kdelibs class. But we can talk about it here first if you prefer :-)

Of course another approach is to say: well, if we change that font dialog so much,
(we added to it the "only scalable fonts" methods already, for koffice)
maybe we want to simply roll out our own. Dunno.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]