[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Bug 76757: page layout. Let me know what you think
From:       p.stirnweiss_koffice () bluewin ! ch
Date:       2004-08-12 16:04:27
Message-ID: 40F7A9ED000B31C7 () mssbzhb-int ! msg ! bluewin ! ch
[Download RAW message or body]


>-- Message original --
>From: David Faure <faure@kde.org>
>To: For developer's discussion about KOffice <koffice-devel@mail.kde.org>
>Date: Wed, 11 Aug 2004 21:50:18 +0200
>Subject: Re: Bug 76757: page layout. Let me know what you think
>Reply-To: For developer's discussion about KOffice <koffice-devel@mail.kde.org>
>
>
>On Wednesday 11 August 2004 14:25, p.stirnweiss_koffice@bluewin.ch wrote:
>> To make sure I understood properly let's take the example of the Orientation
>> part of the page layout. For now it is a QButtonGroup with a QGridLayout
>> inside (which has the 2*margin hint). This QGridLayout could be replaced
>> by a QHGroupBox because it is a 1 row by 4 columns grid. 1st cell Portrait
>> icon, 2nd cell Portrait radio button, 3rd cell landscape icon, 4th cell
>landscape
>> radio button. You actually mean : replace the gridlayout by a HGroupBox.
>> 
>> Have I understood correctly?
>
>Yes, that's one way of doing it - when there's only one row there isn't
really
>a need
>for a grid.

OK I have sussed it out. Replacing the QGridLayout by a QHGroupBox did not
work because it would remove the title of the QButtonGroup and draw lines
arround the widgets inside. The solution I used is : make the QButtonGroup
a QHButtonGroup. It works.
For the page size I had to use a QVGroupBox with QHBoxes inside. It works
too.

The thing I don't get is : why the Q....Box and Q....Group draw a proper
space between the title and the widget where the Q...Layouts nested in a
Q...Group don't. (I am not sure I made myself clear).

Pierre

>
>In other (more complex) cases you can also keep the grid, and put it inside
>the
>Q[HV]GroupBox.
>
>> Anyway, I still think these two patches are necessary as I am not sure
>the
>> margin hints gain is going to be enough.
>
>Not sure I understand that part - my point is simply that the 2*marginHint
>is a hack,
>which might break with bigger fonts, and the real solution is Q[HV]GroupBox.
>But this has nothing to do with making dialogs smaller indeed, it was a
side
>note.
>
>About the actual patch: is it really necessary to reduce the height of the
>page layout
>dialog further? It's 513 pixels here - the goal is < 600, no?
>
>> Furthermore, when I understand a bit more what character style is about
>and
>> implies coding wise, I will probably be quite interested in participating
>> in the redesign of these dialogs.
>
>OK
>
>-- 
>David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
>Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
>_______________________________________________
>koffice-devel mailing list
>koffice-devel@mail.kde.org
>https://mail.kde.org/mailman/listinfo/koffice-devel

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]