[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [Bug 45822] opening files from sftp doesn't work
From:       David Faure <faure () kde ! org>
Date:       2004-04-23 9:28:58
Message-ID: 20040423092858.17470.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
      
http://bugs.kde.org/show_bug.cgi?id=45822      




------- Additional Comments From faure kde org  2004-04-23 11:28 -------
I can reproduce the crash (only when using the filedialog, not when passing an sftp \
url on the command line)

In the KSpreadView constructor:
1690        d->adjustActions( !d->activeSheet->isProtected() );
(gdb) p d->activeSheet
$1 = (class KSpreadSheet *) 0x0

I'll add an obvious null-pointer check, although I think the line might not be
necessary, since setActiveTable calls this already.

Ah, this isn't enough. New crash:
#1  0x41cf5262 in KSpreadSheet::cellAt(int, int, bool) (this=0x0, _column=1, _row=1, \
_scrollbar_update=false)  at \
/mnt/devel/kde/kdecvs/koffice/kspread/kspread_sheet.cc:637 #2  0x41ca5626 in \
KSpreadSelection::extendToMergedAreas(QRect) const (this=0x8318b28, area={x1 = 1, y1 \
= 1, x2 = 1, y2 = 1})  at \
/mnt/devel/kde/kdecvs/koffice/kspread/kspread_selection.cc:252 #3  0x41ca4bf7 in \
KSpreadSelection::selection() const (this=0x8318b28) at \
/mnt/devel/kde/kdecvs/koffice/kspread/kspread_selection.cc:81 #4  0x41ceb99b in \
KSpreadView::closeEditor() (this=0x8378978) at \
/mnt/devel/kde/kdecvs/koffice/kspread/kspread_view.cc:6681 #5  0x41c33176 in \
KSpreadDoc::addView(KoView*) (this=0x81523a8, _view=0x8378978)

Check added to KSpreadView::closeEditor()

And another crash...
#1  0x41ce1f0b in KSpreadView::refreshView() (this=0x82a4458) at \
/mnt/devel/kde/kdecvs/koffice/kspread/kspread_view.cc:4810 4810      bool active = \
table->getShowFormula(); (gdb) p table
$1 = (class KSpreadSheet *) 0x0
(from KSpreadView::resizeEvent)

And another one in KSpreadView::guiActivateEvent... :(
And... hmm, now in KSpreadView::initialPosition, which proves it's called too early.

... moved some code around...
OK, almost works now. Problems with local files....
No time for finishing today, will do this weekend.

Morality: the "view" constructor should NOT assume that the document has been loaded \
yet, this is not the case for documents coming from the network.
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]