[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: patch for bug 68952 (geometric series)
From:       Marc Heyvaert <marc_heyvaert () yahoo ! com>
Date:       2003-12-14 7:36:49
[Download RAW message or body]


--- Clarence Dang <dang@kde.org> wrote:
> Well yes, but it's certainly better than KSpread
> locking up, IMHO.  Of course, 
> an alternative would be to disable the Ok button
> until a legal series is 
> entered.  Seeing as though a) the error message
> doesn't really add to the 
> user's understanding of problem b) KOffice is still
> in a string freeze; maybe 
> it would good idea to change your patch in this way
> (and remove the existing 
> messages as well)?
> 

Well, all the other errors are 'trapped' by the use of
error messages popping up...so for the sake of
consistency :-)

There is also another case that is not catered for yet
: a geometric series with step = 1, so another patch
will be needed.

I am also working on the code that constructs the
series in ...sheet.cc. I see quite some problems
there. E.g. extra care is taken with the
undo-functionality to be sure to include merged cells,
but existing data is merrily overwritten without the
least of warnings. There is also a lot of checking
going on ( a lot of loop constructs, room for some
efficiency improvemente there...) but no safeguard
against overflow. So if you construct a 10.000 numbers
series, vertical starting say at cell A32600, the code
will start to emit error messages (start kspread in a
console to see it) but continue to run. And so on...

So if my patch doesn't get accepted right away because
of the freese, it doesn't worry me too much. There is
so much more that needs to be done on this little bit
of code, that this one patch that I already made isn't
going to make the difference.

Marc

__________________________________
Do you Yahoo!?
New Yahoo! Photos - easier uploading and sharing.
http://photos.yahoo.com/
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]