[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [Bug 61571] Alt+F4 on changed document does only save it,
From:       Thomas Zander <zander () planescape ! com>
Date:       2003-08-12 11:40:56
[Download RAW message or body]

On Tue, Aug 12, 2003 at 12:22:26PM +0200, David Faure wrote:
> On Sunday 03 August 2003 14:03, Clarence Dang wrote:
> > I think there's a missing break for "case KMessageBox::Yes" - this might be 
> > causing a few bugs....
> 
> Indeed.
> 
> The braces in the No case are useless though (no local variables).

I heard Clarence say something about code style; I'm not convinced; but I
can hardly say I know the codestyle of KDE (or KOffice) anymore :}

> > Also it removes the additional filedialog for when the document is non-native 
> > for the following reasons:
> > 
> > 1. the number of dialogs the user gets for using external file formats is 
> > already painful
> > 2. the user is already warned in exportConfirmation (but can turn it off via 
> > DoNotAskAgain, if they really want)
> > 3. popping up a filedialog in queryClose if the doc is non-native and 
> > isModified is inconsistent seeing as though the user could save the document 
> > in the non-native format first before quitting and avoid the filedialog
> > 
> > Comments?
> 
> So there is nothing that forces the user to save into the native format before
> closing, when (s)he's been working with a non-native format all the time?
> I feel this is a bit dangerous - depending on the non-native format.
> But I might be misunderstanding.


The current way seems good to me as well.
And:
> > 3. popping up a filedialog in queryClose if the doc is non-native and 
> > isModified is inconsistent seeing as though the user could save the document 
> > in the non-native format first before quitting and avoid the filedialog
That is not true; only when he set the DoNotAskAgain for that, which has
no bearing on this feature removal.

The only addition that seems appropriate to me is that the same DoNotAskAgain
context is used here as it is for the export itself.
Removing a confirmation dialog is always slippery, and the reasons you
propose seem vague at best.
The bugfix is good though; don't add a feature addition to it please.

-- 
Thomas Zander

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]