[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [Bug 61571] Alt+F4 on changed document does only save it,
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2003-08-12 10:22:26
[Download RAW message or body]

On Sunday 03 August 2003 14:03, Clarence Dang wrote:
> 
> Hi all,
> 
> See attachment.
> 
> I think there's a missing break for "case KMessageBox::Yes" - this might be 
> causing a few bugs....

Indeed.

The braces in the No case are useless though (no local variables).

> Also it removes the additional filedialog for when the document is non-native 
> for the following reasons:
> 
> 1. the number of dialogs the user gets for using external file formats is 
> already painful
> 2. the user is already warned in exportConfirmation (but can turn it off via 
> DoNotAskAgain, if they really want)
> 3. popping up a filedialog in queryClose if the doc is non-native and 
> isModified is inconsistent seeing as though the user could save the document 
> in the non-native format first before quitting and avoid the filedialog
> 
> Comments?

So there is nothing that forces the user to save into the native format before
closing, when (s)he's been working with a non-native format all the time?
I feel this is a bit dangerous - depending on the non-native format.
But I might be misunderstanding.

-- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]