[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patches for review
From:       Werner Trobin <trobin () kde ! org>
Date:       2003-08-07 9:57:43
[Download RAW message or body]

On Thursday 07 August 2003 11:50, Clarence Dang wrote:
> 
> Hi,
> 
> On Wed, 6 Aug 2003 08:19 pm, Lukáš Tinkl wrote:
> > KOffice is effectively in feature freeze now which means no commits unless
> > reviewed here on this list.
> 
> Speaking of which:  :)
> 
> 1. The attached patch ensures that the correct mouse cursor is used when 
> KoFilterManager pops up KoFilterChooser.  Is this ok to commit?

Yes, this one looks good to me.
 
> 2. Could someone please review the fix I posted to bug #61571 so that it can 
> be closed?

I don't understand that patch. The braces you added in the no-case don't 
change anything. The removal of the isNative variable looks wrong to me, but 
I didn't look at that code for a looong time.

Ciao,
Werner
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]