[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [PATCH] filters/kspread/csv
From:       Carsten Niehaus <cniehaus () gmx ! de>
Date:       2003-06-28 16:44:42
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

Looking at the code I found that you used #include <foo.h> instead of #include 
"foo.h". I don't know if that is coding-style in KOffice or has a reason I 
don't see.

Anyway, here is the patch.

Carsten

PS: please CC me, I am not on this list.
- -- 
Beware of bugs in the above code; I have only proved it correct, not tried it.
		-- Donald Knuth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE+/cX829GaGyAowFcRAk7CAKCbmm6tNKQG2g9hKXvZMN5vAC8rPwCcCAQe
2pMPNt2d+Op/D1s2u7/6e18=
=nKiA
-----END PGP SIGNATURE-----

["includepatch.diff" (text/x-diff)]

Index: csvdialog.cpp
===================================================================
RCS file: /home/kde/koffice/filters/kspread/csv/csvdialog.cpp,v
retrieving revision 1.17
diff -u -3 -p -r1.17 csvdialog.cpp
--- csvdialog.cpp	26 Apr 2003 15:45:35 -0000	1.17
+++ csvdialog.cpp	28 Jun 2003 16:40:16 -0000
@@ -17,8 +17,8 @@
    Boston, MA 02111-1307, USA.
 */
 
-#include <dialogui.h>
-#include <csvdialog.h>
+#include "dialogui.h"
+#include "csvdialog.h"
 
 #include <qtable.h>
 #include <qcheckbox.h>
@@ -525,4 +525,4 @@ void CSVDialog::ignoreDuplicatesChanged(
   fillTable();
 }
 
-#include <csvdialog.moc>
+#include "csvdialog.moc"
Index: csvexport.cc
===================================================================
RCS file: /home/kde/koffice/filters/kspread/csv/csvexport.cc,v
retrieving revision 1.24
diff -u -3 -p -r1.24 csvexport.cc
--- csvexport.cc	8 Feb 2003 08:52:51 -0000	1.24
+++ csvexport.cc	28 Jun 2003 16:40:16 -0000
@@ -17,8 +17,6 @@
    Boston, MA 02111-1307, USA.
 */
 
-#include <csvexport.h>
-
 #include <qfile.h>
 
 #include <kdebug.h>
@@ -31,7 +29,8 @@
 #include <kspread_doc.h>
 #include <kspread_view.h>
 
-#include <csvexportdialog.h>
+#include "csvexportdialog.h"
+#include "csvexport.h"
 
 typedef KGenericFactory<CSVExport, KoFilter> CSVExportFactory;
 K_EXPORT_COMPONENT_FACTORY( libcsvexport, CSVExportFactory( "csvfilter" ) );
@@ -269,4 +268,4 @@ KoFilter::ConversionStatus CSVExport::co
   return KoFilter::OK;
 }
 
-#include <csvexport.moc>
+#include "csvexport.moc"
Index: csvexportdialog.cpp
===================================================================
RCS file: /home/kde/koffice/filters/kspread/csv/csvexportdialog.cpp,v
retrieving revision 1.3
diff -u -3 -p -r1.3 csvexportdialog.cpp
--- csvexportdialog.cpp	8 Feb 2003 08:52:51 -0000	1.3
+++ csvexportdialog.cpp	28 Jun 2003 16:40:16 -0000
@@ -17,8 +17,8 @@
    Boston, MA 02111-1307, USA.
 */
 
-#include <csvexportdialog.h>
-#include <exportdialogui.h>
+#include "csvexportdialog.h"
+#include "exportdialogui.h"
 
 #include <kspread_map.h>
 #include <kspread_sheet.h>
Index: csvimport.cc
===================================================================
RCS file: /home/kde/koffice/filters/kspread/csv/csvimport.cc,v
retrieving revision 1.24
diff -u -3 -p -r1.24 csvimport.cc
--- csvimport.cc	21 Mar 2003 19:42:43 -0000	1.24
+++ csvimport.cc	28 Jun 2003 16:40:16 -0000
@@ -17,7 +17,6 @@
    Boston, MA 02111-1307, USA.
 */
 
-#include <csvimport.h>
 
 #include <qfile.h>
 
@@ -34,7 +33,8 @@
 #include <kspread_style_manager.h>
 #include <kspread_cell.h>
 
-#include <csvdialog.h>
+#include "csvdialog.h"
+#include "csvimport.h"
 
 // hehe >:->
 
@@ -201,4 +201,4 @@ KoFilter::ConversionStatus CSVFilter::co
     return KoFilter::OK;
 }
 
-#include <csvimport.moc>
+#include "csvimport.moc"
Index: xmltree.cc
===================================================================
RCS file: /home/kde/koffice/filters/kspread/csv/xmltree.cc,v
retrieving revision 1.13
diff -u -3 -p -r1.13 xmltree.cc
--- xmltree.cc	21 Apr 2000 11:50:24 -0000	1.13
+++ xmltree.cc	28 Jun 2003 16:40:16 -0000
@@ -17,7 +17,7 @@
    Boston, MA 02111-1307, USA.
 */
 
-#include <xmltree.h>
+#include "xmltree.h"
 
 #include <qdatetime.h>
 #include <kdebug.h>


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]