[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Kword tables - m_cells removal semi-complete
From:       Thomas Zander <zander () planescape ! com>
Date:       2003-06-09 10:09:08
[Download RAW message or body]

Looks very nice :)

Thanx for your work on this!

On Sun, Jun 08, 2003 at 06:14:25PM +1000, Carl G Lewis wrote:
> Hi, 
> 
> I have posted a patch here:
> http://www.members.optushome.com.au/carll/
> 
> that removes the m_cells list from class KWTableFrameSet.
> 
> This has meant heavy modifications to the class, including all the table 
> operation functions for inserting/deleteing/splitting/joining, etc.
> 
> There are still some bugs. Row and column operations seem pretty stable, and 
> although splitting and joining work in most cases, it's still possible to 
> cause a crash here. However, considering the state of CVS at the moment, this 
> is a big improvement. Undo/redo for table ops also seems mostly ok.
> 
> The biggest caveat is that multi-page operation is not tested and is not 
> expected to work. However, given how buggy multipage tables are anyway, I 
> don't see this as a problem :-)  I have some ideas that will radically change 
> how multipage stuff is handled, so I am not inclined to debug the code that 
> is already there. 
> 
> I have posted the patch and some test scripts so that if anyone wants to 
> comment they can, if there are no objections I will commit this tomorrow as 
> I'd like to have it in the next beta. Once that's done, I'll post a proposal 
> for the next set of changes (including handling multipage and fixing table 
> drawing).
> 
> Carl.

-- 
Thomas Zander

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]