[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Kword tables + patches
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2003-05-07 12:56:19
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 07 May 2003 12:53, Carl G Lewis wrote:
> 
> > Do you want a CVS account, to commit those changes yourself and keep
> > working on the code? See
> > http://developer.kde.org/documentation/other/developer-faq.html#q8
> >
> I now have a login as "clewis". What is the procedure for commits? Do you want 
> me to make patches available first for review/approval ? 
> I will commit the current patches by the weekend.

It depends how confident in your patches you are, and whether you want peer review
or not :)
I'm happy to review patches, but I'll have a look at what you commit in any case,
so there's no need for you to post everything here first, at least concerning kwtableframeset
since you'll be the only one working on it for now.

> > > Not all the changes are so easy. m_pageBoundaries is a big hassle because
> > > it contains indexes into m_cells, so every bit of code that uses it has
> > > to be touched.
> 
> Actually I was wrong about this! Sort of. It turns out there are actually two 
> different comments that describe m_pageBoundaries differently. In 
> kwtableframeset.h, at the declaration of m_pageBoundaries, and in 
> kwtableframeset.cc, at KWTableFrameSet::contains(). The first seems to 
> correspond to the majority of the code. I suppose contains() must not be 
> called. Most of the time, m_pageBoundaries holds indexes into m_rowPositions, 
> not m_cells (I think).

Right, it contains a row number - which can be used as an index
into any row array, but not necessarily; most code just uses "int row".

> I will investigate whether contains() is ever called, 
> since it seems plainly incorrect.
Wow, indeed. Thomas, are you reading? :)

It makes much more sense for it to contain a row number than a cell number, anyway.
One can only break between rows, not between arbitrary cells...

> Anyway this makes the m_cells conversion less work. There may be a bit more 
> refactoring before it is done though. I am particularly keen to break up 
> recalcRows() into a few methods.
No objections :)

- -- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+uQJz72KcVAmwbhARAnEiAKCf2DeDAcgDh8ihuUdvN1giCarXdgCbB+lq
MkPJTVNtQVl8UjLcIgefwE0=
=pvug
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]